On Sun, Sep 14, 2025 at 12:59:49PM -0700, Jakub Kicinski wrote: > On Fri, 12 Sep 2025 08:59:13 -0700 Breno Leitao wrote: > > @@ -1225,9 +1242,7 @@ static noinline_for_stack int > > ethtool_get_rxrings(struct net_device *dev, > > if (ret) > > return ret; > > > > - ret = ops->get_rxnfc(dev, &info, NULL); > > - if (ret < 0) > > - return ret; > > + info.data = ethtool_get_rx_ring_count(dev); > > Is there a reason we're no longer checking for negative errno here? > It's possible that none of the drivers actually return an error, but > we should still check. For consistency with the other patches / paths > if nothing else.
Agree, we need to check the result of ethtool_get_rx_ring_count, and return it if negative. I will update the patchset.
