On 9/30/25 3:20 PM, Erikas Bitovtas wrote:
> Add an initial device tree for Asus ZenFone 2 Laser/Selfie. This
> includes support for:
> - UART
> - USB
> - Internal storage
> - MicroSD
> - Volume keys
> - Touchscreen: Focaltech FT5306
> - Accelerometer: Invensense MPU6515
> - Magnetometer: Asahi Kasei AK09911
> - Vibrator
> - Audio input and output
> - Modem
>
> Signed-off-by: Erikas Bitovtas <[email protected]>
> ---
[...]
> +&blsp_uart2 {
> + pinctrl-0 = <&blsp_uart2_console_default>;
> + pinctrl-1 = <&blsp_uart2_console_sleep>;
> + pinctrl-names = "default", "sleep";
> + status = "okay";
nit: a newline before 'status' is customary
[...]
> +&tlmm {
> + gpio_keys_default: gpio-keys-default-state {
> + pins = "gpio107", "gpio117";
pin configuration nodes are best sorted by their pin number, please
reshuffle them
https://docs.kernel.org/devicetree/bindings/dts-coding-style.html#order-of-nodes
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + imu_default: imu-default-state {
> + pins = "gpio36";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + mag_reset_default: mag-reset-default-state {
> + pins = "gpio112";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-disable;
odd \n-s in some entries, please remove them
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
