Hi Andrew, On Fri, Oct 10, 2025 at 08:01:10AM -0500, Andrew Davis wrote: >On 10/5/25 9:14 AM, Peng Fan wrote: >> Per Documentation/process/coding-style.rst rule 17 regarding the use of >> bool types: >> If a structure has many true/false values, consider consolidating them into >> a bitfield with 1-bit members, or using an appropriate fixed-width type >> such as u8. >> >> This commit replaces multiple bool members in struct rproc with 1-bit >> bitfields and groups them together. This change reduces the overall size of >> struct rproc from 0x4d8 to 0x4c8 on ARM64. >> > >Most of the series looks good, but this patch I'm not a fan. This isn't >a huge savings and bitfields come with many of their own challenges.
Thanks for giving a look on the patchset. I could drop this change in V3. May I get your R-b for other patches? (V2 was just posted out after fixed stm32_rproc build issue) > >> No functional changes. > >If the structure's size changed then that is a functional change. There Got it. >also is probably a performance change from extracting the value out of the >bitfield, where before they might have each been an aligned width variable >that could be tested in a single cycle. Agree, but performance may not be critical here. No problem, I could drop this patch. Let me wait to collect more comments. Thanks, Peng > >Andrew >
