On Mon, Sep 29, 2025 at 06:42:53AM -0700, Alok Tiwari wrote:
> When query_virtqueues() fails, the error log prints the variable err
> instead of cmd->err. Since err may still be zero at this point, the
> log message can misleadingly report a success value 0 even though the
> command actually failed.
>
> Even worse, once err is set to the first failure, subsequent logs
> print that same stale value. This makes the error reporting appear
> one step behind the actual failing queue index, which is confusing
> and misleading.
>
> Fix the log to report cmd->err, which reflects the real failure code
> returned by the firmware.
>
> Fixes: 1fcdf43ea69e ("vdpa/mlx5: Use async API for vq query command")
> Signed-off-by: Alok Tiwari <[email protected]>
Thanks for catching and fixing this Alok. The patch is straightforward
and it looks good to me:
Reviewed-by: Dragos Tatulea <[email protected]>
Thanks,
Dragos
