On Tue, Oct 21, 2025 at 12:17 AM Michael S. Tsirkin <[email protected]> wrote: > > On Mon, Oct 20, 2025 at 03:10:01PM +0800, Jason Wang wrote: > > Factor out the split indirect descriptor detaching logic in order to > > allow it to be reused by the in order support. > > > > Acked-by: Eugenio Pérez <[email protected]> > > Reviewed-by: Xuan Zhuo <[email protected]> > > Signed-off-by: Jason Wang <[email protected]> > > --- > > drivers/virtio/virtio_ring.c | 63 ++++++++++++++++++++---------------- > > 1 file changed, 35 insertions(+), 28 deletions(-) > > > > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c > > index c59e27e2ad68..0f07a6637acb 100644 > > --- a/drivers/virtio/virtio_ring.c > > +++ b/drivers/virtio/virtio_ring.c > > @@ -771,11 +771,42 @@ static bool virtqueue_kick_prepare_split(struct > > vring_virtqueue *vq) > > return needs_kick; > > } > > > > +static void detach_indirect_split(struct vring_virtqueue *vq, > > + unsigned int head) > > +{ > > + struct vring_desc_extra *extra = vq->split.desc_extra; > > + struct vring_desc *indir_desc = > > + vq->split.desc_state[head].indir_desc; > > why split this line? it's not too long. >
Fixed. Thanks
