On Mon, Oct 20, 2025 at 3:43 AM Mike Rapoport <[email protected]> wrote: > > On Sat, Oct 18, 2025 at 01:17:47PM -0400, Pasha Tatashin wrote: > > Allow to do finalize and abort from kernel modules, so LUO could > > We surely don't want modules being able to drive that. Maybe > > allow kernel to drive finalize and abort without requiring triggers > from the userspace
done > > > drive the KHO sequence via its own state machine. > > > > Signed-off-by: Pasha Tatashin <[email protected]> > > Reviewed-by: Pratyush Yadav <[email protected]> > > --- > > include/linux/kexec_handover.h | 15 +++++++ > > kernel/kexec_handover.c | 74 ++++++++++++++++++++-------------- > > 2 files changed, 59 insertions(+), 30 deletions(-) > > ... > > > diff --git a/kernel/kexec_handover.c b/kernel/kexec_handover.c > > index 76f0940fb485..76c34ea923f0 100644 > > --- a/kernel/kexec_handover.c > > +++ b/kernel/kexec_handover.c > > @@ -1067,7 +1067,7 @@ static int kho_out_update_debugfs_fdt(void) > > return err; > > } > > > > -static int kho_abort(void) > > +static int __kho_abort(void) > > { > > int err; > > unsigned long order; > > @@ -1100,7 +1100,27 @@ static int kho_abort(void) > > return err; > > } > > > > -static int kho_finalize(void) > > +int kho_abort(void) > > +{ > > + int ret = 0; > > + > > + if (!kho_enable) > > + return -EOPNOTSUPP; > > + > > + guard(mutex)(&kho_out.lock); > > Please include linux/cleanup.h explicitly That is going to be included via kfence fixes which will come before this patch. > > > + if (!kho_out.finalized) > > + return -ENOENT; > > + > > ... > > > -unlock: > > - mutex_unlock(&kho_out.lock); > > - return ret; > > + return (!!_val) ? kho_finalize() : kho_abort(); > > An 'if' would be cleared IMO: > > if (val) > return kho_finalize(); > else > return kho_abort(); > > and we can rename u64 _val to u64 val as we are dropping the boolean. done > > > } > > -- > Sincerely yours, > Mike.
