On 10/18/2025 10:46 AM, Alok Tiwari wrote:
Caution: This message originated from an External Source. Use proper caution 
when opening attachments, clicking links, or responding.


Use %pe instead of %ps when printing ERR_PTR() values. %ps is intended
for string pointers, while %pe correctly prints symbolic error names
for error pointers returned via ERR_PTR().
This shows the returned error value more clearly.

Fixes: 67f27b8b3a34 ("pds_vdpa: subscribe to the pds_core events")
Signed-off-by: Alok Tiwari <[email protected]>
---
  drivers/vdpa/pds/vdpa_dev.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM. Thanks.

Reviewed-by: Brett Creeley <[email protected]>


diff --git a/drivers/vdpa/pds/vdpa_dev.c b/drivers/vdpa/pds/vdpa_dev.c
index 36f61cc96e21..43426bd971ac 100644
--- a/drivers/vdpa/pds/vdpa_dev.c
+++ b/drivers/vdpa/pds/vdpa_dev.c
@@ -51,7 +51,7 @@ static int pds_vdpa_register_event_handler(struct 
pds_vdpa_device *pdsv)
                 err = pdsc_register_notify(nb);
                 if (err) {
                         nb->notifier_call = NULL;
-                       dev_err(dev, "failed to register pds event handler: 
%ps\n",
+                       dev_err(dev, "failed to register pds event handler: %pe\n" 
>                                  ERR_PTR(err));
                         return -EINVAL;
                 }
--
2.50.1


Reply via email to