On Feb 3, 2008 11:20 PM, Andi Kleen <[EMAIL PROTECTED]> wrote: > On Sun, Feb 03, 2008 at 10:13:53PM -0800, Russell Leidich wrote: > > All, > > > > You can imagine my dismay when I recently learned that, after all our > > collective effort, hardware thermal throttling does not work reliably > > on Barcelona, according to AMD. Due to NDA restrictions, I am unable > > to provide further details. > > Too bad. Hopefully that code will work then on the hypothetic > future parts with fixed throttling. Perhaps it would be better > to just remove it now and readd later.
I really think it's best to leave it in. It's harmless at the moment, and readding it later will just create a massive amount of duplicate work. Sooner or later, I'm have little doubt that AMD can make this feature work. > > All this reminds me you need to adjust the Kconfig dependencies > for K8_NB too to be always enabled with MCE_AMD. > > Ideally on top of this patch with a || MCE_AMD OK, if you'll take the patch, I'd be happy to do this :). I'm assuming that you mean I should force K8_NB = "yes" if MCE_AMD = "yes" in .config. Is that what you're asking for? > > -Andi > > --- > > Fix and simplify k8.c Kconfig dependencies > > - Check for K8_NUMA instead of NUMA && PCI > - No need to check for x86_64 explicitely > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> > > Index: linux/arch/x86/Kconfig > =================================================================== > --- linux.orig/arch/x86/Kconfig > +++ linux/arch/x86/Kconfig > @@ -1540,7 +1540,7 @@ endif # X86_32 > > config K8_NB > def_bool y > - depends on AGP_AMD64 || (X86_64 && (GART_IOMMU || (PCI && NUMA))) > + depends on AGP_AMD64 || GART_IOMMU || K8_NUMA > > source "drivers/pcmcia/Kconfig" > > -- Russell Leidich -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
