On Fri, Nov 21, 2025 at 12:49:04PM +0000, Andre Carvalho wrote:
> + echo "${BINDMODE} : Test passed" >&2
> +done
> +
> +trap - EXIT
> +exit "${ksft_pass}"
Shellcheck complains about this line given that it expects that exported
variables from other files are always uppercase. I'm going to submit a new
version of this test using ${EXIT_STATUS} instead, which is the same approach
taken by a netcons_torture.sh which was recently added.
We may want to refactor these tests to make use of other selftest's functions
that actually mutate EXIT_STATUS based on the intermediary results of the tests
(by using log_test and other functions from lib.sh) which I think may also
help with making result logging a bit more in line with other tests. I'd like to
do this in a separate series and migrate all tests, if we agree on this
direction.
>
> --
> 2.52.0
>
--
Andre Carvalho
