On Thu, Nov 27, 2025 at 10:14:01AM +0300, Dan Carpenter wrote:
> The devm_ioremap_resource_wc() function never returns NULL, it returns
> error pointers. Update the error checking to match.
>
> Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for
> "memory-region"")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/remoteproc/imx_dsp_rproc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_dsp_rproc.c
> b/drivers/remoteproc/imx_dsp_rproc.c
> index be83b5f20f15..5130a35214c9 100644
> --- a/drivers/remoteproc/imx_dsp_rproc.c
> +++ b/drivers/remoteproc/imx_dsp_rproc.c
> @@ -710,9 +710,9 @@ static int imx_dsp_rproc_add_carveout(struct
> imx_dsp_rproc *priv)
> return -EINVAL;
>
> cpu_addr = devm_ioremap_resource_wc(dev, &res);
> - if (!cpu_addr) {
> + if (IS_ERR(cpu_addr)) {
> dev_err(dev, "failed to map memory %pR\n", &res);
> - return -ENOMEM;
> + return PTR_ERR(cpu_addr);
Applied.
Thanks,
Mathieu
> }
>
> /* Register memory region */
> --
> 2.51.0
>
