2025-11-29, 12:07:26 +0530, Ankit Khushwaha wrote: > In 'poll_partial_rec_async' a uninitialized char variable 'token' with > *garbage* value is used for write/read instruction to synchronize > between threads via a pipe. > > tls.c:2833:26: warning: variable 'token' is uninitialized > when passed as a const pointer argument here > [-Wuninitialized-const-pointer] > 2833 | EXPECT_EQ(write(p[1], &token, 1), 1); /* Barrier #1 */ > > Initialize 'token' to '\0' to prevent write/read of garbage value.
I'm not opposed to making the compiler happy, but in this case "garbage" is completely fine, we don't care about the value. So I think the subject and the commit message should talk about "silencing a compiler warning" rather than "fixing use of garbage value". And your patch should indicate the target tree in the subject (here, with [PATCH net-next]), see https://www.kernel.org/doc/html/next/process/maintainer-netdev.html -- Sabrina
