On 01/12/2025 13:48, Konrad Dybcio wrote:
> On 11/30/25 1:08 AM, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <[email protected]>
>>
>> The lab and ibb regulators aren't used here. Disable them.
>>
>> Removes following warnings:
>> qcom-lab-ibb-regulator c440000.spmi:pmic@3:labibb: Failed to create device
>> link (0x180) with supplier c440000.spmi for
>> /soc@0/spmi@c440000/pmic@3/labibb/lab
>> qcom-lab-ibb-regulator c440000.spmi:pmic@3:labibb: Failed to create device
>> link (0x180) with supplier c440000.spmi for
>> /soc@0/spmi@c440000/pmic@3/labibb/ibb
>
> These are only vaguely related, as there's nothing to be wary about that's
> specific to these devices - it's just devlink being grumpy
>
>> Fixes: 288ef8a42612 ("arm64: dts: sdm845: add oneplus6/6t devices")
>> Signed-off-by: David Heidelberg <[email protected]>
>> ---
>> I assume this is right approach, as OLEDs on both devices are driven by
>> different regulators.
>>
>> Question is, if should be labibb nodes enabled by default?
>
> They're onboard. I'd rather keep them predictably parked than left in
> whatever (potentially ON) state the bootloader may leave them at
Shouldn't they be default disabled in the pmic dtsi and only enabled on
the devices that actually use them? Many SDM845 devices with OLED panels
don't use these regulators.
>
> Konrad
--
// Casey (she/her)
