On 12/1/25 10:04 PM, [email protected] wrote: > On 12/1/25 5:21 AM, Konrad Dybcio wrote: >> On 11/29/25 2:32 AM, Alexandru Gagniuc wrote: >>> The "wcss_q6_bcr_reset" is not used on IPQ8074, and IPQ6018. Use >>> devm_reset_control_get_optional_exclusive() for this reset so that >>> probe() does not fail on platforms where it is not used. >>> >>> Signed-off-by: Alexandru Gagniuc <[email protected]> >>> --- >> >> This reset is not even used (or documented anywhere).. the closest >> I can find is "wcss_q6_reset" in qcom,q6v5.txt, initially documented >> in: >> >> Fixes: 3a3d4163e0bf ("remoteproc: qcom: Introduce Hexagon V5 based WCSS >> driver") >> >> which claims it was made for.. IPQ8074 >> >> Peeking at the GCC driver, this reset is most likely present as >> GCC_WCSS_Q6_BCR > > The downstream kernel uses GCC_WCSS_Q6_BCR for ipq8074 [1] and ipq6018 [2]. > They only use of ->wcss_q6_bcr_reset in the QCN404 path, which does not use > ->wcss_q6_reset. So maybe we can get away with calling it "wcss_q6_reset", > store the pointer in ->wcss_q6_reset, and drop '.wcss_q6_reset_required'
"BCR reset" is like saying "PIN number", both of the ones you mentioned are referring to the same thing Konrad
