On Thu, Dec 18, 2025 at 10:34:10PM -0600, Alexandru Gagniuc wrote: > Document the IPQ9574 native (non-PAS) WCSS image loader. It is similar > to IPQ8074 WCSS, but requires several new clocks. These clocks must be > enabled by the host in non-PAS mode, and are not optional. Add an > example that uses the "qcom,ipq9574-wcss-pil" binding. > > Signed-off-by: Alexandru Gagniuc <[email protected]> > --- > .../remoteproc/qcom,ipq8074-wcss-pil.yaml | 115 +++++++++++++++++- > 1 file changed, 113 insertions(+), 2 deletions(-) > > diff --git > a/Documentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml > b/Documentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml > index dea46cb9f93fe..a665b704a835f 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,ipq8074-wcss-pil.yaml > @@ -18,6 +18,7 @@ properties: > compatible: > enum: > - qcom,ipq8074-wcss-pil > + - qcom,ipq9574-wcss-pil > - qcom,qcs404-wcss-pil > > reg: > @@ -49,10 +50,10 @@ properties: > - const: wcss_q6_reset > > clocks: > - maxItems: 10
Either you miss minItems or you are changing existing devices without any explanation. > + maxItems: 13 > > clock-names: > - maxItems: 10 > + maxItems: 13 > > cx-supply: > description: > @@ -107,6 +108,7 @@ allOf: > contains: > enum: > - qcom,ipq8074-wcss-pil > + - qcom,ipq9574-wcss-pil > then: > properties: > qcom,smem-states: > @@ -117,9 +119,47 @@ allOf: > items: > - const: shutdown > - const: stop So why all devices have now 13 clocks? > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,ipq8074-wcss-pil Just keep the if:then: per device, don't mix it up. > + then: > + properties: > clock-names: false > clocks: false Best regards, Krzysztof
