On Sun, Jan 18, 2026 at 09:28:35AM +0100, Dirk Behme wrote:
[...]
> > + /// ```
> > + pub fn dereference<'rcu>(&self, _rcu_guard: &'rcu Guard) ->
> > Option<P::Borrowed<'rcu>> {
> > + // Ordering: Address dependency pairs with the `store(Release)` in
> > copy_update().
> > + let ptr = self.as_atomic().load(Relaxed);
> > +
> > + if !ptr.is_null() {
> > + // SAFETY:
>
>
> Would it be an option to take an early return here and with this drop
> one indentation level of the larger `SAFETY` comment?
>
> if ptr.is_null() {
> return None;
> }
>
> // SAFETY:
> ...
> Some(unsafe { P::borrow(ptr) })
>
> Same for `Drop for Rcu<P>` below.
>
>
Make sense.
> > + // - Since `ptr` is not null, so it has to be a return value
> > of `P::into_foreign()`.
> > + // - The returned `Borrowed<'rcu>` cannot outlive the RCU
> > Guar, this guarantees the
>
> Guar -> Guard
>
Fixed! Thank you!
Regards,
Boqun
