Jan 30, 2026 17:17:46 Jakub Kicinski <[email protected]>: > On Fri, 30 Jan 2026 11:34:15 +0100 Thomas Weißschuh wrote: >>> Are all those selftests / samples getting broken by this patch set? >> >> Yes. >> >> Some of them get broken by the new 'struct sockaddr', but some others are >> already broken just by the new transitive inclusion of libc-compat.h. >> So any header starting to use the compatibility machinery may trigger >> breakage >> in code including UAPI headers before libc header, even for completely new >> type >> definitions which themselves would not conflict with libc. > > Let's split the uAPI header changes from any selftest changes. > If you're saying the the selftests no longer build after the uAPI > header changes then of course we can't apply the patches.
Yes, the selftests don't build anymore after the uAPI changes. "can't apply" as in * "can't apply separately" * "are unacceptable in general" * "are too late for this cycle" ? None of this is urgent. We can do the selftests in one cycle and the uAPI in another one. Feel free to pick up the patches as you see fit. (The mptcp changes already go through their tree, so need to be dropped here) I can also resubmit the patches differently if preferred. Thomas
