> Subject: [PATCH] remoteproc: imx_rproc: Check return value of
> regmap_attach_dev() in imx_rproc_mmio_detect_mode()
>
> Add error checking for regmap_attach_dev() call in
> imx_rproc_mmio_detect_mode() function to ensure proper error
> propagation.
>
> Return the value of regmap_attach_dev() if it fails to prevent
> proceeding with an incomplete regmap setup.
>
> Signed-off-by: Chen Ni <[email protected]>
> ---
> drivers/remoteproc/imx_rproc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c
> b/drivers/remoteproc/imx_rproc.c index f5f916d67905..0e23f519c247
> 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1007,7 +1007,9 @@ static int
> imx_rproc_mmio_detect_mode(struct rproc *rproc)
> }
>
> priv->regmap = regmap;
> - regmap_attach_dev(dev, regmap, &config);
> + ret = regmap_attach_dev(dev, regmap, &config);
> + if (ret)
> + return dev_err_probe(dev, ret, "regmap attach
> failed\n");
In the main probe, there is already dev_err_probe for
detect_mode. So I would use below style as other error
return in imx_rproc_mmio_detect_mode():
dev_err("regmap attach failed\n");
return ret;
Let's wait Mathieu's view.
Regards
Peng.
>
> if (priv->gpr) {
> ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> --
> 2.25.1
>
