On Sat, Feb 07, 2026 at 08:01:31PM -0800, Douglas Anderson wrote:
> As per the patch ("mailbox: Deprecate NULL mbox messages; Introduce
> mbox_ring_doorbell()"), we want to switch all users of NULL mailbox
> messages to use mbox_ring_doorbell().
>
> This client only ever sent NULL messages, so the transition is
> straightforward. We can remove the call to mbox_client_txdone(). The
> call didn't do anything for NULL messages and it's now officially
> documented not to be called for doorbells.
>
> Signed-off-by: Douglas Anderson <[email protected]>
Acked-by: Bjorn Andersson <[email protected]>
Regards,
Bjorn
> ---
>
> (no changes since v1)
>
> drivers/rpmsg/qcom_glink_smem.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c
> index 7a982c60a8dd..f2a6d94e72ea 100644
> --- a/drivers/rpmsg/qcom_glink_smem.c
> +++ b/drivers/rpmsg/qcom_glink_smem.c
> @@ -197,8 +197,7 @@ static void glink_smem_tx_kick(struct qcom_glink_pipe
> *glink_pipe)
> struct glink_smem_pipe *pipe = to_smem_pipe(glink_pipe);
> struct qcom_glink_smem *smem = pipe->smem;
>
> - mbox_send_message(smem->mbox_chan, NULL);
> - mbox_client_txdone(smem->mbox_chan, 0);
> + mbox_ring_doorbell(smem->mbox_chan);
> }
>
> static irqreturn_t qcom_glink_smem_intr(int irq, void *data)
> --
> 2.53.0.rc2.204.g2597b5adb4-goog
>
