On 2/8/26 13:30, Peng Fan (OSS) wrote: > From: Peng Fan <[email protected]> > > Smatch reports unreachable code in imx_rproc_prepare(), where an early > return inside the reserved-memory parsing loop prevents platform > prepare_ops from being executed. > > When of_reserved_mem_region_to_resource() fails, imx_rproc_prepare() > returns immediately, so the platform-specific prepare callback is never > called. As a result, prepare_ops such as imx_rproc_sm_lmm_prepare() on > i.MX95 have no chance to run. > > This is problematic when Linux controls the M7 Logical Machine and is > responsible for preparing resources such as TCM. Without running the > platform prepare callback, loading the M7 ELF into TCM may fail if the > bootloader did not power up and initialize TCM. > > Fix this by breaking out of the reserved-memory loop instead of > returning, allowing the platform prepare_ops to be executed as intended. > > Fixes: edd2a9956055 ("remoteproc: imx_rproc: Introduce prepare ops for > imx_rproc_dcfg") > Reported-by: Dan Carpenter <[email protected]> > Closes: https://lore.kernel.org/linux-remoteproc/aYYXAa2Fj36XG4yQ@p14s/T/#t > Signed-off-by: Peng Fan <[email protected]>
Reviewed-by: Daniel Baluta <[email protected]>
