On 2/21/26 9:55 PM, Paul Adam via B4 Relay wrote:
> From: Paul Adam <[email protected]>
>
> Add an initial device tree for Wiko PULP 4G.
> Includes support for:
> - UART
> - USB (no OTG)
> - Internal storage
> - MicroSD
> - Volume keys + Power button
> - Touchscreen
> - Backlight
> - Accelerometer: Invensense MPU6880
> - Magnetometer: Asahi Kasei AK09911
> - Hall sensor: Rohm BU52021HFV
> - Proximity sensor
> - Vibrator
> - Earpiece
> - Microphone 1
> - Headphones
> - Wifi
> - Bluetooth
> - GPU
>
> Signed-off-by: Paul Adam <[email protected]>
> ---
[...]
> + backlight: backlight {
> + compatible = "pwm-backlight";
> + pwms = <&pm8916_pwm 0 100000>;
> + brightness-levels = <0 255>;
> + num-interpolated-steps = <255>;
> + default-brightness-level = <255>;
> + enable-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&button_backlight_default>;
> + pinctrl-1 = <&button_backlight_off>;
> + pinctrl-names = "default", "off";
"off" seems unused, this should be "suspend", however the difference
between the two states is already handled by the enable-gpio in the
driver, so you can omit the second state
[...]
> + };
> +
> + keys {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&keys_default>;
> + pinctrl-names = "default";
> + label = "GPIO Buttons";
Sorry for not being clear, I was okay with the gpio- prefix in the node
name, but I intended to ask to remove it from the label..
> +
> + button-volume-up {
> + label = "Volume up";
> + gpios = <&tlmm 107 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_VOLUMEUP>;
> + };
> + };
> +
> + hall-sensor {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&hall_sensor_default>;
> + pinctrl-names = "default";
> + label = "GPIO Hall Effect Sensor";
> +
> + event-hall-sensor {
> + label = "Hall Effect Sensor";
> + gpios = <&tlmm 117 GPIO_ACTIVE_LOW>;
> + linux,input-type = <EV_SW>;
> + linux,code = <SW_LID>;
> + linux,can-disable;
> + };
[...]
> +&pm8916_pwm {
> + pinctrl-0 = <&pwm_out>;
> + pinctrl-names = "default";
> + status = "okay";
> +};
> +
> +&pm8916_resin {
> + linux,code = <KEY_VOLUMEDOWN>;
> + status = "okay";
Please add a \n before status in nodes where there's more than just
that property
[...]
> +&tlmm {
> + button_backlight_default: button-backlight-default-state {
> + pins = "gpio119";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> + button_backlight_off: button-backlight-off-state {
> + pins = "gpio119";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-disable;
> + output-low;
> + };
This can now be removed (it had incorrect indent anyway)
Konrad
