> diff --git a/tools/testing/selftests/bpf/bpf_experimental.h 
> b/tools/testing/selftests/bpf/bpf_experimental.h
> --- a/tools/testing/selftests/bpf/bpf_experimental.h
> +++ b/tools/testing/selftests/bpf/bpf_experimental.h

[ ... ]

> +/* Description
> + *   Remove 'node' from the BPF linked list with head 'head'.
                                                          ^^^^^^

The comment references a 'head' parameter, but the function signature
only takes 'node':

> + */
> +extern struct bpf_list_node *bpf_list_del(struct bpf_list_node *node) __ksym;

This looks like a leftover from v1 where bpf_list_del() took both
head and node. Alexei asked to drop the head parameter in v1 review:

https://lore.kernel.org/bpf/CAADnVQKjBdfL17d0H6eHdiHYbXOr0Xz6BC=abwmctq6860-...@mail.gmail.com/

The implementation was updated but the comment still references the
removed parameter. Should this say something like "Remove 'node'
from its BPF linked list" instead?


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/22391130139

AI-authorship-score: low
AI-authorship-explanation: Follows established BPF selftest patterns with 
idiomatic kernel C; the stale v1 comment is a typical human oversight when 
iterating on review feedback.
issues-found: 1
issue-severity-score: low
issue-severity-explanation: Stale documentation comment referencing a removed 
parameter; no runtime impact but incomplete response to maintainer review 
feedback.

Reply via email to