On Tue, Feb 24, 2026 at 11:56 PM Pranjal Shrivastava <[email protected]> wrote:
> On Thu, Jan 29, 2026 at 09:24:54PM +0000, David Matlack wrote:

> >  int __init vfio_pci_liveupdate_init(void)
> >  {
> > +     int ret;
> > +
> >       if (!liveupdate_enabled())
> >               return 0;
> >
> > -     return liveupdate_register_file_handler(&vfio_pci_liveupdate_fh);
> > +     ret = liveupdate_register_file_handler(&vfio_pci_liveupdate_fh);
> > +     if (ret)
> > +             return ret;
>
> Nit: We might need to handle the retval here if we remove the
> liveupdate_enabled() check above (as discussed in patch 2).

I think you mean for the below call to pci_liveupdate_register_fh(),
but yes agreed :).

Reply via email to