From: Konstantin Khorenko <[email protected]>

The pmtu.sh kselftest sets up a multi-namespace test topology where the
host network itself is part of the test setup. Test packets originating
from the created namespace are expected to reach test interface created
in the host. When firewall rules are present on the host, this traffic
may be blocked, causing the test to fail.

Run the test in an isolated network namespace to avoid interference
from host firewall rules.

Signed-off-by: Konstantin Khorenko <[email protected]>
Signed-off-by: Aleksei Oladko <[email protected]>
---
 tools/testing/selftests/net/Makefile     | 3 ++-
 tools/testing/selftests/net/pmtu-test.sh | 4 ++--
 tools/testing/selftests/net/pmtu.sh      | 4 ++++
 3 files changed, 8 insertions(+), 3 deletions(-)
 create mode 100755 tools/testing/selftests/net/pmtu.sh

diff --git a/tools/testing/selftests/net/Makefile 
b/tools/testing/selftests/net/Makefile
index b9eeeffa5fd2..363cd1e2cf8e 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -63,7 +63,7 @@ TEST_PROGS := \
        netns-name.sh \
        netns-sysctl.sh \
        nl_netdev.py \
-       pmtu-test.sh \
+       pmtu.sh \
        psock_snd.sh \
        reuseaddr_ports_exhausted.sh \
        reuseport_addr_any.sh \
@@ -194,6 +194,7 @@ TEST_FILES := \
        fcnal-test.sh \
        in_netns.sh \
        lib.sh \
+       pmtu-test.sh \
        settings \
 # end of TEST_FILES
 
diff --git a/tools/testing/selftests/net/pmtu-test.sh 
b/tools/testing/selftests/net/pmtu-test.sh
index a3323c21f001..2ba6bc0252f0 100755
--- a/tools/testing/selftests/net/pmtu-test.sh
+++ b/tools/testing/selftests/net/pmtu-test.sh
@@ -976,7 +976,7 @@ setup_ovs_bridge() {
        run_cmd ip link set ovs_br0 up
 
        run_cmd ${ns_c} ip link add veth_C-A type veth peer name veth_A-C
-       run_cmd ${ns_c} ip link set veth_A-C netns 1
+       run_cmd ${ns_c} ip link set veth_A-C netns $$
 
        run_cmd         ip link set veth_A-C up
        run_cmd ${ns_c} ip link set veth_C-A up
@@ -985,7 +985,7 @@ setup_ovs_bridge() {
        setup_ovs_add_if veth_A-C
 
        # Move veth_A-R1 to init
-       run_cmd ${ns_a} ip link set veth_A-R1 netns 1
+       run_cmd ${ns_a} ip link set veth_A-R1 netns $$
        run_cmd ip addr add ${prefix4}.${a_r1}.1/${veth4_mask} dev veth_A-R1
        run_cmd ip addr add ${prefix6}:${a_r1}::1/${veth6_mask} dev veth_A-R1
        run_cmd ip link set veth_A-R1 up
diff --git a/tools/testing/selftests/net/pmtu.sh 
b/tools/testing/selftests/net/pmtu.sh
new file mode 100755
index 000000000000..1805fa44a2de
--- /dev/null
+++ b/tools/testing/selftests/net/pmtu.sh
@@ -0,0 +1,4 @@
+#!/bin/sh
+# SPDX-License-Identifier: GPL-2.0
+
+./in_netns.sh ./pmtu-test.sh "$@"
-- 
2.43.0


Reply via email to