Hi, On Fri, Mar 06, 2026 at 10:03:20PM +0800, zhidao su wrote: > From: Su Zhidao <[email protected]> > > This series does a small cleanup pass on the sched_ext bypass code path > and adds a selftest for the bypass mechanism. > > Patch 1 removes SCX_OPS_HAS_CGROUP_WEIGHT, which was marked deprecated > in 6.15 with a "will be removed on 6.18" comment. We are now past that > point.
See: https://lore.kernel.org/all/[email protected]/ > > Patches 2-3 improve the bypass code in ext.c: add inline comments > explaining the bypass depth counter semantics and the dequeue/enqueue > re-queue loop, and replace rcu_dereference_all() with the more precise > rcu_dereference_bh() in scx_bypass_lb_timerfn() which runs in softirq > context. These patches don't really improve code, they just add comments. Which is nice, it's good to improve documentation, but documentation should help understand better the high-level semantic, or clarify non-obvious implemenatation details. In this case you're just commenting how the specific code works, which should be already clear enough just by looking at the code IMHO. > > Patch 4 adds a selftest that verifies forward progress under bypass > mode: worker processes are spawned while the scheduler is active, then > bpf_link__destroy() is called (triggering bypass), and the test confirms > all workers complete successfully. Already commented on the patch. > > Patch 5 adds a comment to the scx_bypass_depth declaration noting its > planned migration into struct scx_sched. Ditto about documentation. Thanks, -Andrea
