On Tue, Mar 10, 2026 at 06:21:34PM +0100, Barnabás Czémán wrote:
> Add devicetree for Redmi 5A based on msm8917-xiaomi-wingtech.
> 
> Signed-off-by: Barnabás Czémán <[email protected]>
> ---
>  arch/arm64/boot/dts/qcom/Makefile                |  1 +
>  arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts | 56 
> ++++++++++++++++++++++++
>  2 files changed, 57 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile 
> b/arch/arm64/boot/dts/qcom/Makefile
> index e68e161cfec0..6d87be639aac 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -81,6 +81,7 @@ dtb-$(CONFIG_ARCH_QCOM)     += msm8916-wingtech-wt86518.dtb
>  dtb-$(CONFIG_ARCH_QCOM)      += msm8916-wingtech-wt86528.dtb
>  dtb-$(CONFIG_ARCH_QCOM)      += msm8916-wingtech-wt88047.dtb
>  dtb-$(CONFIG_ARCH_QCOM)      += msm8916-yiming-uz801v3.dtb
> +dtb-$(CONFIG_ARCH_QCOM)      += msm8917-xiaomi-riva.dtb
>  dtb-$(CONFIG_ARCH_QCOM)      += msm8929-wingtech-wt82918hd.dtb
>  dtb-$(CONFIG_ARCH_QCOM)      += msm8937-xiaomi-land.dtb
>  dtb-$(CONFIG_ARCH_QCOM)      += msm8939-asus-z00t.dtb
> diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts 
> b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
> new file mode 100644
> index 000000000000..02d9d4fd1b45
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
> @@ -0,0 +1,56 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2026, Barnabas Czeman
> + */
> +
> +/dts-v1/;
> +
> +#include "msm8917-xiaomi-wingtech.dtsi"
> +
> +/ {
> +     model = "Xiaomi Redmi 5A (riva)";
> +     compatible = "xiaomi,riva", "qcom,msm8917";
> +
> +     qcom,board-id = <0x1000b 1>, <0x1000b 2>;
> +
> +     battery: battery {
> +             compatible = "simple-battery";
> +             charge-full-design-microamp-hours = <3000000>;
> +             energy-full-design-microwatt-hours = <11500000>;
> +             constant-charge-current-max-microamp = <1000000>;
> +             constant-charge-voltage-max-microvolt = <4400000>;
> +             precharge-current-microamp = <256000>;
> +             charge-term-current-microamp = <60000>;
> +             voltage-min-design-microvolt = <3400000>;
> +     };
> +};
> +
> +&blsp2_i2c1 {
> +     status = "okay";
> +
> +     bq27426@55 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
If you cannot find a name matching your device, please check in kernel
sources for similar cases or you can grow the spec (via pull request to
DT spec repo).

> +             compatible = "ti,bq27426";
> +             reg = <0x55>;
> +             monitored-battery = <&battery>;
> +     };
> +
> +     bq25601@6b {

Same here.


Best regards,
Krzysztof


Reply via email to