On Wed, Mar 11, 2026 at 01:38:03PM +0200, Erikas Bitovtas wrote: > Add supply, I2C and cathode voltage regulators to the sensor and enable > them. This keeps the sensor powered on even after its only supply shared > by another device shuts down.
> Signed-off-by: Erikas Bitovtas <[email protected]> > Reported-by: Raymond Hackley <[email protected]> Where was it reported? Do you need Closes tag? ... > +#include "linux/array_size.h" > +#include "linux/regulator/consumer.h" Double quotes, huh?! > #include <linux/bitfield.h> > #include <linux/module.h> > #include <linux/i2c.h> Also, please keep the list ordered. ... > mutex_init(&data->vcnl4000_lock); > + ret = devm_regulator_bulk_get_enable(&client->dev, > + ARRAY_SIZE(regulator_names), > + regulator_names); > + if (ret < 0) > + return ret; You can't add devm_ after non-devm calls. Also it would help you to have struct device *dev = &client->dev; at the top of the function. ... With the above being said, I expect a series out of two patches at least. -- With Best Regards, Andy Shevchenko
