Aleksei Oladko <[email protected]> writes: > The pmtu.sh kselftest configures OVS using ovs-dpctl.py and falls back > to ovs-vsctl only when ovs-dpctl.py fails. However, ovs-dpctl.py exits > with a success status when the installed pyroute2 package version is > lower than 0.6, even though the OVS datapath is not configured. > > As a result, pmtu.sh assumes that the setup was successful and > continues running the test, which later fails due to the missing > OVS configuration. > > Fix the exit code handling in ovs-dpctl.py so that pmtu.sh can detect > that the setup did not complete successfully and fall back to > ovs-vsctl. > > Fixes: 962e8a01eab9 ("selftests: openvswitch: Add version check for pyroute2") > Signed-off-by: Aleksei Oladko <[email protected]> > ---
Still LGTM (but this is already in net-next as 0bcac7b11262 so does it need to be included still? Actually I think it should be in 'net') (including tag just in case) Reviewed-by: Aaron Conole <[email protected]>
