On Thu, Mar 12, 2026 at 07:58:04AM +0000, cristian_ci wrote:
>
> On Tuesday, March 10th, 2026 at 23:30, Dmitry Baryshkov
> <[email protected]> wrote:
>
> > On Tue, Mar 10, 2026 at 04:42:43PM +0000, cristian_ci wrote:
> > > On Tuesday, March 10th, 2026 at 12:28, Konrad Dybcio
> > > <[email protected]> wrote:
> > >
> > > > On 3/8/26 4:01 PM, Dmitry Baryshkov wrote:
> > > > > On Sun, Mar 08, 2026 at 04:52:43PM +0100, Cristian Cozzolino via B4
> > > > > Relay wrote:
> > > > >> From: Cristian Cozzolino <[email protected]>
> > > > >>
> > > > >> Add the description for the display panel found on this phone.
> > > > >> And with this done we can also enable the GPU and set the zap shader
> > > > >> firmware path.
> > > > >>
> > > > >> Signed-off-by: Cristian Cozzolino <[email protected]>
> > > > >> ---
> > > > >> .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 80
> > > > >> ++++++++++++++++++++++
> > > > >> 1 file changed, 80 insertions(+)
> > > > >>
> > > > >> +
> > > > >> +&mdss_dsi0 {
> > > > >> + vdda-supply = <&pm8953_s3>;
> > > > >> + vddio-supply = <&pm8953_l6>;
> > > > >> +
> > > > >> + pinctrl-0 = <&mdss_default>;
> > > > >> + pinctrl-1 = <&mdss_sleep>;
> > > > >> + pinctrl-names = "default", "sleep";
> > > > >
> > > > > It might be better to move pinctrl nodes to the panel device, because
> > > > > they control the panel reset pin (rather than some kind if DSI-related
> > > > > pin).
> > > >
> > > > +1, perhaps let's rename that pin to panel_reset while at it
> > >
> > > So, something like (plus related renaming in tlmm node):
> > >
> > > panel: panel@0 {
> > > compatible = "novatek,nt35532";
> > > reg = <0>;
> > >
> > > backlight = <&pmi8950_wled>;
> > > reset-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>;
> > > vsp-supply = <&lab>;
> > > vsn-supply = <&ibb>;
> > >
> > > pinctrl-0 = <&panel_default>;
> > > pinctrl-1 = <&panel_reset>;
> > > pinctrl-names = "default", "reset";
> >
> > No, "reset" would not be recognized. Use "sleep" as before.
>
> so, something like:
>
> pinctrl-1 = <&panel_sleep>;
> pinctrl-names = "default", "sleep";
>
> ?
>
> Also, should I remove 'sleep' state if panel handles only one state
> ('default')
> instead of two states (like mdss)?
Yes, DSI panels don't have (and don't use) a separate sleep pinctrl
state.
>
> > >
> > > port {
> > > panel_in: endpoint {
> > > remote-endpoint = <&mdss_dsi0_out>;
> > > };
> > > };
> > > };
> > >
> > > this?
> > >
> > > > Konrad
> > > >
> > >
> > > Regards
> >
> > --
> > With best wishes
> > Dmitry
> >
--
With best wishes
Dmitry
