On Sat, 14 Mar 2026 02:42:28 Alexei Starovoitov wrote: > On Fri, Mar 13, 2026 at 6:55=E2=80=AFAM <[email protected]> wrote: > > > > > diff --git a/tools/testing/selftests/bpf/progs/verifier_ctx_ptr_param.c= > b/tools/testing/selftests/bpf/progs/verifier_ctx_ptr_param.c > > > new file mode 100644 > > > index 000000000000..b507dc850543 > > > --- /dev/null > > > +++ b/tools/testing/selftests/bpf/progs/verifier_ctx_ptr_param.c > > > > [ ... ] > > > > > +SEC("fentry/bpf_fentry_test_ppfile") > > > +__description("fentry/struct file***: struct file *** inferred as scal= > ar") > > > > The description says "struct file ***" (triple pointer), but > > bpf_fentry_test_ppfile() takes a struct file ** (double pointer): > > > > net/bpf/test_run.c: > noinline void bpf_fentry_test_ppfile(struct file **ppf) > > > > Should the description be > > "fentry/struct file**: struct file ** inferred as scalar" instead? > > Pls don't ignore bot reviews... > Do you agree or not?
I'm not ignoring the bot - I'm in Australia and pushed this patch late at night at 12:05 AM Saturday. The bot replied 50 minutes later at 12:55 AM Saturday, and I was already not at my desktop. I will make the necessary changes to the test description. The bot is correct that it should have been "struct file **" - I mistakenly carried over the triple pointer description when copy-pasting the comments.
