On Sat, Mar 14, 2026 at 06:06:33PM +0200, Erikas Bitovtas wrote:
> Add supply, I2C and cathode voltage regulators to the sensor and enable
> them. This keeps the sensor powered on even after its only supply shared
> by another device shuts down.
...
> + ret = devm_regulator_bulk_get_enable(dev,
Below is broken indentation.
> + ARRAY_SIZE(regulator_names),
There is still some room on the previous line.
> + regulator_names);
ret = devm_regulator_bulk_get_enable(dev, ARRAY_SIZE(regulator_names),
regulator_names);
OTOH the logical split is rather to have the last two on a single line, but
that one becomes too long, so your initial variant is okay with fixed
indentation.
ret = devm_regulator_bulk_get_enable(dev,
ARRAY_SIZE(regulator_names),
regulator_names);
> + if (ret < 0)
Do we need ' < 0' part?
> + return ret;
--
With Best Regards,
Andy Shevchenko
