On 18/03/2026 07:57, Hannes Reinecke wrote:
+static inline int scsi_alua_stpg_run(struct scsi_device *sdev, bool optimize)+{ + return 0; +} static inline int scsi_alua_sdev_init(struct scsi_device *sdev) { return 0;No. STPG handling should be done in scsi_dh_alua _only_. We really should not attempt this in the scsi core.
It's not so nice to have the functionality spread out. The way I see it is that drivers/scsi/scsi_alua.c is mostly a library, but also has functionality to "drive" ALUA for native SCSI multipathing.
Anyway, can you confirm which of the following do you think from this series should be in scsi_dh_alua.c:
- scsi_alua_stpg_run() - scsi_alua_stpg() - submit_stpg() You already said scsi_alua_stpg_run() should be. Thanks, John
