On Thu, Mar 19, 2026 at 08:43:47AM +0000, Ben Copeland wrote:
> The alsa kselftests are missing a config file to declare their required
> kernel configuration options. This causes the utimer-test (timer_f.utimer)
> to fail on kernels without CONFIG_SND_UTIMER enabled, as the
> SNDRV_TIMER_IOCTL_CREATE ioctl returns -1.
> 
> Add the config file with the necessary sound configs so that
> 'make kselftest-merge' can enable them automatically.

These tests fit awkwardly into the config fragment stuff, since pcm-test
and mixer-test are mostly testing drivers we should in theory have every
single audio driver enabled as part of the fragment, but that is
annoying to maintain and bloaty.  Fortunately people usually put these
in their defconfigs so we actually do the right thing in practice most
of the time without the need to build a custom kernel.  On the other
hand the test-pcmtest-driver test requires a test module which *does*
need a config option so it requires a cutom config.

Separately to what we're doing here utimer-test ought to skip rather
than fail if the driver it needs isn't present just as a general
kselftest style thing, I see it's not doing that now.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Attachment: signature.asc
Description: PGP signature

Reply via email to