On Sun, Mar 22, 2026 at 12:30:53PM -0700, Ethan Luna wrote: > Multiple block comments in tpm_i2c_atmel.c placed the closing '*/' on the > same line as the comment text. This violates the kernel's preferred > comment style, which requires the closing delimiter to appear on it's > line. > > Fix the formatting to improve readability and resolve checkpatch > warnings. > > Signed-off-by: Ethan Luna <[email protected]> > --- > drivers/char/tpm/tpm_i2c_atmel.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/tpm/tpm_i2c_atmel.c > b/drivers/char/tpm/tpm_i2c_atmel.c > index 4f229656a8e2..702b3c9191dc 100644 > --- a/drivers/char/tpm/tpm_i2c_atmel.c > +++ b/drivers/char/tpm/tpm_i2c_atmel.c > @@ -33,7 +33,8 @@ struct priv_data { > size_t len; > /* This is the amount we read on the first try. 25 was chosen to fit a
If you fix this up here. > * fair number of read responses in the buffer so a 2nd retry can be > - * avoided in small message cases. */ > + * avoided in small message cases. > + */ > u8 buffer[sizeof(struct tpm_header) + 25]; > }; > > @@ -58,7 +59,9 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, > size_t bufsiz, > if (status < 0) > return status; > > - /* The upper layer does not support incomplete sends. */ > + /* > + * The upper layer does not support incomplete sends. > + */ > if (status != len) > return -E2BIG; > > @@ -78,7 +81,8 @@ static int i2c_atmel_recv(struct tpm_chip *chip, u8 *buf, > size_t count) > > /* Get the message size from the message header, if we didn't get the > * whole message in read_status then we need to re-read the > - * message. */ > + * message. > + */ > expected_len = be32_to_cpu(hdr->length); > if (expected_len > count) > return -ENOMEM; > @@ -113,13 +117,15 @@ static u8 i2c_atmel_read_status(struct tpm_chip *chip) > > /* The TPM fails the I2C read until it is ready, so we do the entire > * transfer here and buffer it locally. This way the common code can > - * properly handle the timeouts. */ > + * properly handle the timeouts. > + */ > priv->len = 0; > memset(priv->buffer, 0, sizeof(priv->buffer)); > > > /* Once the TPM has completed the command the command remains readable > - * until another command is issued. */ > + * until another command is issued. > + */ > rc = i2c_master_recv(client, priv->buffer, sizeof(priv->buffer)); > dev_dbg(&chip->dev, > "%s: sts=%d", __func__, rc); > @@ -174,7 +180,8 @@ static int i2c_atmel_probe(struct i2c_client *client) > > /* There is no known way to probe for this device, and all version > * information seems to be read via TPM commands. Thus we rely on the > - * TPM startup process in the common code to detect the device. */ > + * TPM startup process in the common code to detect the device. > + */ > > return tpm_chip_register(chip); > } > -- > 2.53.0 > The same comment applies for all. BR, Jarkko
