On Wed, Mar 25, 2026 at 06:31:47PM +0000, cristian_ci wrote: > On Tuesday, March 24th, 2026 at 23:20, Dmitry Baryshkov > <[email protected]> wrote: > > > On Tue, Mar 24, 2026 at 01:10:13PM +0000, cristian_ci wrote: > > > On Saturday, March 21st, 2026 at 17:46, Dmitry Baryshkov > > > <[email protected]> wrote: > > > > In the lack of any information, this is probably as good as anything > > else. Please describe in your commit message that you don't know the > > exact vendor of the panel (nor the id of the panel). > > Ok, apart adding a new compatible ("flipkart,rimob-panel-nt35532-cs") to > dt-bindings (patch 1/6) - leaving "novatek,nt35532" as fallback - and > setting that to panel node (patch 3/6), I'll have to change (patch 2/6) > too, by renaming nt35532_on to rimob_panel_on and so on for nt35532_off, > nt35532_mode; by adding a new struct named rimob_panel_desc defining
struct nt35532_panel_desc > .mode, .on, .off members and moving .lanes, .format and .mode_flags from > nt35532_probe to this new desc specific struct and by adding .data argument I'd say, keep it simple. Move just let that struct have .mode and .on. I think the rest can be generic until somebody needs those. > to nt35532_of_match. What about the other nt35532 functions (i.e. > nt35532_reset)? You don't need to complicate the driver, keep the reset as is. -- With best wishes Dmitry
