The -EEXIST errno is reserved by the module loading functionality. When userspace calls [f]init_module(), it expects a -EEXIST to mean that the module is already loaded in the kernel. If module_init() returns it, that is not true anymore.
Override the error when returning to userspace: it doesn't make sense to change potentially long error propagation call chains just because it's will end up as the return of module_init(). Closes: https://lore.kernel.org/all/[email protected]/ Cc: Greg Kroah-Hartman <[email protected]> Cc: Aaron Tomlin <[email protected]> Cc: Petr Pavlu <[email protected]> Cc: Daniel Gomez <[email protected]> Cc: Phil Sutter <[email protected]> Cc: Christophe Leroy <[email protected]> Signed-off-by: Lucas De Marchi <[email protected]> --- kernel/module/main.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/module/main.c b/kernel/module/main.c index c3ce106c70af..3b60b7cda329 100644 --- a/kernel/module/main.c +++ b/kernel/module/main.c @@ -3045,6 +3045,14 @@ static noinline int do_init_module(struct module *mod) if (mod->init != NULL) ret = do_one_initcall(mod->init); if (ret < 0) { + /* + * -EEXIST is reserved by [f]init_module() to signal to usersapace that + * a module with this name is already loaded. Use something else if the + * module itself returning that. + */ + if (ret == -EEXIST) + ret = -EBUSY; + goto fail_free_freeinit; } if (ret > 0) { -- 2.53.0
