On 02/03/2026 14:58, John Garry wrote:
Given how little code this removes while adding the new libmultipath
dependency and abstractions I can't say I like this at all.



I have been doing some code trimming, and now I am getting a diff like this:

 drivers/nvme/host/core.c      |  84 ++--
 drivers/nvme/host/ioctl.c     | 110 ++--
 drivers/nvme/host/multipath.c | 917 +++++++---------------------------
 drivers/nvme/host/nvme.h      | 144 +++---
 drivers/nvme/host/pr.c        |  18 -
 drivers/nvme/host/sysfs.c     |  86 +---
 6 files changed, 357 insertions(+), 1002 deletions(-)

That is losing 645 LoC - previously it was 282. Would that be a sort of acceptable diff?
Obviously that is before thorough review (so prone to change).

Reply via email to