On Thu, 7 Feb 2008 11:04:12 -0800 Randy Dunlap <[EMAIL PROTECTED]> wrote:
> On Thu, 7 Feb 2008 17:42:51 +0100 Jean Delvare wrote: > > > Hi Randy, > > > > On Wed, 6 Feb 2008 16:27:54 -0800, Randy Dunlap wrote: > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > > > Add I2C to config since the driver makes several i2c*() calls. > > > > Correct. > > > > > > > > Add PCI to config because the config selects I2C_I801, which depends > > > on PCI, but currently config* does not follow dependency chains, > > > so randconfig can enable INPUT_APANEL even when PCI is not enabled, > > > which leads to these warnings: > > > linux-2.6.24-mm1/drivers/i2c/busses/i2c-i801.c:641: error: implicit > > > declaration of function 'pci_request_region' > > > /linux-2.6.24-mm1/drivers/i2c/busses/i2c-i801.c:681: error: implicit > > > declaration of function 'pci_release_region' > > > > I'd rather drop the "select I2C_I801" if the config system can't handle > > it properly. It's not strictly needed (not a build-time dependency), an > > addition to the help text would work as well. Adding dependencies to > > make our selections happy is a bit confusing and likely to cause > > trouble in the future (as dependencies can change...) > > OK. What did you have in mind for the help text. I changed it > a small bit. > > I also added "depends on LEDS_CLASS" since defconfig didn't have that > set, but the build failed with wanting symbols that it provides. > > Updated patch: > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > From: Randy Dunlap <[EMAIL PROTECTED]> > > Add I2C to config since the driver makes several i2c*() calls. > > Add to help text that the Intel I2C ICH (i801) driver is also needed > for this kernel. > > Add LEDS_CLASS to config since the driver makes les_classdev_*() calls: > ERROR: "led_classdev_register" [drivers/input/misc/apanel.ko] undefined! > ERROR: "__led_classdev_unregister" [drivers/input/misc/apanel.ko] undefined! > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> On a related note, Ubuntu puts the i2c_i801 module in /etc/modprobe.d/blacklist. To get the apanel to work, this must be removed, but that is a distro bug. -- Stephen Hemminger <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
