On Sat, Apr 04, 2026 at 10:05:14AM +0100, Simon Horman wrote:
> On Thu, Apr 02, 2026 at 11:26:55AM -0700, Erni Sri Satya Vennela wrote:
> > Use pci_name(pdev) for the per-device debugfs directory instead of
> > hardcoded "0" for PFs and pci_slot_name(pdev->slot) for VFs. The
> > previous approach had two issues:
> >
> > 1. pci_slot_name() dereferences pdev->slot, which can be NULL for VFs
> > in environments like generic VFIO passthrough or nested KVM,
> > causing a NULL pointer dereference.
> >
> > 2. Multiple PFs would all use "0", and VFs across different PCI
> > domains or buses could share the same slot name, leading to
> > -EEXIST errors from debugfs_create_dir().
> >
> > pci_name(pdev) returns the unique BDF address, is always valid, and
> > is unique across the system.
> >
> > Fixes: 6607c17c6c5e ("net: mana: Enable debugfs files for MANA device")
> > Signed-off-by: Erni Sri Satya Vennela <[email protected]>
>
> Hi Erni,
>
> Possibly the code differs between net and net-next.
> But if this is fixing a bug in code present in net - as per the cited
> commit - then I think it should be a patch that targets net.
> With some strategy for merging that change into net-next
> if conflicts are expected.
Thankyou for the clarity Simon.
I will send a separate patchset for net tree with the fixes.
- Vennela
