On Mon, Apr 13, 2026, Ackerley Tng wrote: > Lisa Wang <[email protected]> writes: > > > > > [...snip...] > > > > tools/testing/selftests/kvm/guest_memfd_test.c | 168 > > +++++++++++++++++++++++++ > > 1 file changed, 168 insertions(+) > > > > Hey Sean, what do you think of adding even more tests to > guest_memfd_test.c? Would you prefer adding memory failure tests > somewhere else? I recall you mentioning something about there being too > many tests in guest_memfd_test.c already.
Hmm, we're definitely accumulating a lot of individual testcases, but up until this one, they're all quite small and so there hasn't been much motiviation to split up guest_memfd_test. But this one's quite the chonker, so I'd say yeah, put the memory failure stuff in it's own test, especially since testing the debugfs path will require elevated permissions for many environments.

