On 5/4/26 3:21 PM, Luca Weiss wrote: > On Mon May 4, 2026 at 3:10 PM CEST, Konrad Dybcio wrote: >> On 5/1/26 11:20 AM, Luca Weiss wrote: >>> Hi Konrad, >>> >>> On Tue Apr 7, 2026 at 3:16 PM CEST, Konrad Dybcio wrote: >>>> On 4/3/26 9:35 PM, Dmitry Baryshkov wrote: >>>>> On Fri, Apr 03, 2026 at 03:52:53PM +0200, Luca Weiss wrote: >>>>>> Configure and enable the WiFi node, and add the required pinctrl to >>>>>> provide the sleep clock from the PMK8550 (PMK7635) to WCN6755. >>>>>> >>>>>> Thanks to Alexander Koskovich for helping with the bringup, adding >>>>>> the missing pinctrl to make the WPSS stop crashing. >>>>>> >>>>>> Link: >>>>>> https://lore.kernel.org/linux-arm-msm/[email protected]/ >>>>>> Reviewed-by: Dmitry Baryshkov <[email protected]> >>>>>> Signed-off-by: Luca Weiss <[email protected]> >>>>>> --- >>>>>> arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts | 19 >>>>>> ++++++++++++++++++- >>>>>> 1 file changed, 18 insertions(+), 1 deletion(-) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>>> b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>>> index db72418b7195..d8ac495ca7c8 100644 >>>>>> --- a/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>>> +++ b/arch/arm64/boot/dts/qcom/milos-fairphone-fp6.dts >>>>>> @@ -242,7 +242,7 @@ wcn6750-pmu { >>>>>> >>>>>> clocks = <&rpmhcc RPMH_RF_CLK1>; >>>>>> >>>>>> - pinctrl-0 = <&bluetooth_enable_default>; >>>>>> + pinctrl-0 = <&bluetooth_enable_default>, >>>>>> <&pmk8550_sleep_clk_default>; >>>>>> pinctrl-names = "default"; >>>>>> >>>>>> regulators { >>>>>> @@ -766,6 +766,17 @@ &pmiv0104_eusb2_repeater { >>>>>> qcom,tune-usb2-preem = /bits/ 8 <0x6>; >>>>>> }; >>>>>> >>>>>> +&pmk8550_gpios { >>>>>> + pmk8550_sleep_clk_default: sleep-clk-default-state { >>>>>> + pins = "gpio5"; >>>>>> + function = "func1"; >>>>>> + input-disable; >>>>>> + output-enable; >>>>> >>>>> Hmm, if it's a sleep_clk, should it not be handled via the power >>>>> sequencer? >>>> >>>> If you mean that it may be needed to toggle it with specific timings, >>>> possibly.. seems that WCN6855 has a "xo-clk" GPIO defined. I requested >>>> access to some docs that I think should have the answer, hopefully should >>>> get it soon. >>> >>> Did you manage to get anything there yet? >> >> Yeah, sorry, it got lost in the sea of emails.. >> >> The PDF talks about the electrical requirements of the clock signal and >> the section titled "Power-up sequence timing" doesn't mention it at all, >> so my assumption would be "OK so long as it's ticking before you power >> up the WCN" > > Thanks for checking! > > Is this an R-b then?
Yes Reviewed-by: Konrad Dybcio <[email protected]> Konrad
