Hi Allison, On 20/05/2026 14:22, Allison Henderson wrote: > On Wed, 2026-05-20 at 11:34 +1000, Matthieu Baerts (NGI0) wrote: >> The run.sh script explicitly checks that CONFIG_MODULES is disabled. >> >> By default, this config option is enabled. Explicitly disable it to be >> able to run the RDS tests. >> >> Note that writing '# CONFIG_(...) is not set' is usually recommended to >> disable an option in the .config, but it looks like selftests usually >> set 'CONFIG_(...)=n', which looks clearer.
(...) > The fix looks fine to me. Thanks for catching this. Thank you for the review. Note that NIPA is now validating these tests: https://netdev.bots.linux.dev/contest.html?test=run-sh https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=run-sh Note that it might be good to rename the script name, "run.sh" is a bit too generic :) Cheers, Matt
