err is initialized to -ENOMEM at the start of virtnet_probe(), and no
code path between that and the devm_kzalloc() failure can change
err. Assigning -ENOMEM again before goto free therefore is redundant.

Signed-off-by: Li Wang <[email protected]>
---
 drivers/net/virtio_net.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f4adcfee7a80..1fbafca90e4c 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -6853,10 +6853,8 @@ static int virtnet_probe(struct virtio_device *vdev)
                                rss_max_indirection_table_length));
        }
        vi->rss_hdr = devm_kzalloc(&vdev->dev, virtnet_rss_hdr_size(vi), 
GFP_KERNEL);
-       if (!vi->rss_hdr) {
-               err = -ENOMEM;
+       if (!vi->rss_hdr)
                goto free;
-       }
 
        if (vi->has_rss || vi->has_rss_hash_report) {
                key_sz = virtio_cread8(vdev, offsetof(struct virtio_net_config, 
rss_max_key_size));
-- 
2.34.1


Reply via email to