On Thu, 21 May 2026 16:47:57 +0530 Sarthak Sharma <[email protected]>
wrote:
> gup_test.c currently serves two distinct purposes: microbenchmarking
> (GUP_FAST_BENCHMARK, PIN_FAST_BENCHMARK, PIN_LONGTERM_BENCHMARK) and
> functional correctness testing (GUP_BASIC_TEST, PIN_BASIC_TEST,
> DUMP_USER_PAGES_TEST). Mixing these in a single binary means functional
> tests cannot be run or reported individually and run_vmtests.sh must
> invoke the binary multiple times with different flag combinations to
> cover all configurations.
>
> This patch series separates the two concerns: tools/mm/gup_bench for
> benchmarking and tools/testing/selftests/mm/gup_test for functional
> testing. To avoid duplicating HugeTLB and related file helpers, the
> series first moves the common helper code to tools/lib/mm/ so it can be
> shared by both selftests and tools/mm.
>
> ...
>
Thanks.
> These patches apply on top of mm/mm-new.
>
> Changes in v3:
> - Address v2 feedback from Sashiko
Sashiko has thoughts on v3:
https://sashiko.dev/#/patchset/[email protected]
Probably that's incorrect/ignored material which also appeared against
the v2 series. But sometimes it finds new things so please scan the
output.
I'll hold off on this series for now, shall see what reviewers have to
say.
