Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Mandating backward compatibility with an ancient kernel version (4.12) for all new in-tree selftests violates established upstream kernel principles. --
commit 005a4d6b98d5e0ddf7ab7d595575364d010c4d3f Author: Marcos Paulo de Souza <[email protected]> selftests: livepatch: Add information about minimum kernel support This commit adds a note to the livepatch selftests README. It documents that the current tests are compatible with kernel 4.12 and mandates that all new tests must maintain this backward compatibility. > diff --git a/tools/testing/selftests/livepatch/README > b/tools/testing/selftests/livepatch/README > index d2035dd64a2be..293f4730b9277 100644 > --- a/tools/testing/selftests/livepatch/README > +++ b/tools/testing/selftests/livepatch/README > @@ -54,3 +54,6 @@ check_result(). The latter function greps the kernel's > ring buffer for > those strings for result comparison. Other utility functions include > general module loading and livepatch loading helpers (waiting for patch > transitions, sysfs entries, etc.) > + > +All new tests and test modules MUST be compatible with kernel version 4.12 > and > +later, including current upstream kernels. [Severity: Medium] Does mandating backward compatibility with kernel 4.12 for all new tests conflict with upstream kernel principles? Requiring tests to support an older kernel could block the introduction of tests for any livepatch features developed after 4.12, as the required internal APIs would not exist. This might also force developers to clutter the test module codebase with version checks for old kernels. Should the burden of backporting tests to older enterprise kernels be left to downstream distributions rather than enforced on upstream contributors? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
