June 1, 2026 at 1:08 AM, "SeongJae Park" <[email protected] mailto:[email protected]?to=%22SeongJae%20Park%22%20%3Csj%40kernel.org%3E > wrote:
> > On Sun, 31 May 2026 16:56:28 +0800 Kunwu Chan <[email protected]> wrote: > > > > > From: Kunwu Chan <[email protected]> > > > > This series fixes several bugs in the DAMON selftests. Most are > > trivial but cause tests to silently pass when they shouldn't, or > > fail prematurely on slow machines. > > > Thank you for sharing these great changes, Kunwu and Lian! > > > > > Patch 1 fixes mutable default arguments in DamonCtx.__init__() > > that cause state to leak between test instances. > > > > Patch 2 fixes a trailing comma in DamosFilter that turns > > memcg_path from a string into a tuple, silently breaking memcg > > filter setup. > > > > Patch 3-4 fix bugs in damos_tried_regions.py: wrong operator > > precedence drops the "not met" prefix from failure output, and > > empty early aggregation cycles cause premature test failure. > > > > Patch 5 fixes several wrong strings that produce dead elif > > branches, skipped file existence checks, and broken dict key > > lookups. > > > I left comments to each patch. To summarize, > > Patches 1, 3 and 5 look good except signer/author info mismatch. > > For patches 2 and 4, I think we need more discussions. > Thanks, SJ. Noted. I'll fix the signer/author mismatch in v2. As discussed in the individual replies, I'll drop patches 2 and 4 for now and revisit 4 once the underlying issues are better understood. Thanks, Kunwu > Thanks, > SJ > > [...] >
