On Sat, May 30, 2026 at 05:28:12PM -0700, Eric Biggers wrote: > On Fri, May 22, 2026 at 09:00:46AM +0200, Daniel Vacek wrote:
> It's been really hard to find time to review this huge patchset. I've > started going through it and will try to leave comments next week. Thank you. The patchset is huge but we'd like your feedback namely on the crypto layer changes, i.e. the first 8 patches. As this is outside of btrfs code we can't fix it incrementally later on. The current size of btrfs-only can be slightly reduced but a lot of must stay so it's clear how the fscrypt API is used. I'm not sure if it was mentioned before wrt how to get this merged. My preferred way is to get your Ack for the crypto changes and then we can add it to linux-next via our btrfs git. It's too late for 7.2 also because you've asked for some changes. So the target is 7.3, hopefully giving all of us enough time to have the mergeable version in ~7.2-rc3 timeframe. If you have other ideas how to proceed with the merge process, please let me know. > In the mean time it would be really helpful if you went through the > Sashiko reviews > (https://sashiko.dev/#/patchset/20260513085340.3673127-1-neelx%40suse.com) > and address the ones that make sense to. It found 93 issues including > 16 critical ones, which is kind of a lot. Some of them are the same > things I'm noticing already. Same for the issue that Christoph noticed > where new devices can be added; Sashiko had already found that too. > > If I'm going to have to use my limited human review time to point out > issues that were already found, that's not a great use of time. > > I also don't see any information about how this was tested (and will > continue to be tested in the future). The testing is not straightforward as it needs 3 projects to synchronize, kernel, fstests and btrfs-progs. Testing may need to use custom git branches for all of them. For btrfs-progs the changes will ge it in soon. For fstests it can be a chicken-egg problem, as they don't accept tests for unmerged code. We've been using our fstests [1] with additional fixups (not upstreamable, related to CI workarounds). Though I'm not sure if Daniel has updated the branch with his most recent version. [1] https://github.com/btrfs/fstests branch staging
