Thanks for the feedback, Krzysztof.
Do you mean that the PM8921 USB ID handling should be exposed by the
PM8921 parent node itself, so USB consumers would reference the PMIC
directly, e.g.:
extcon = <&muic>, <&pm8921>;
I am fine with that model, but it would require more driver changes: the
current extcon driver binds to a separate platform device, while the
PM8921 parent node is already handled by the PM8xxx MFD driver.
Is that the direction you would prefer for v4?
--
MINETTE Alexandre
[email protected]
Mar 28 avr 2026, à 08:56, Krzysztof Kozlowski a écrit :
> On Mon, Apr 27, 2026 at 09:34:53PM +0200, Alexandre MINETTE wrote:
>> Add the PM8921 USB ID interrupt as a disabled extcon provider. Boards
>> can enable it when their USB controller consumes the PMIC USB ID state
>> for OTG role detection.
>>
>> The interrupt corresponds to PM8921 USB_ID_IN, block 6 bit 1.
>>
>> Signed-off-by: Alexandre MINETTE <[email protected]>
>> ---
>> arch/arm/boot/dts/qcom/pm8921.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom/pm8921.dtsi
>> b/arch/arm/boot/dts/qcom/pm8921.dtsi
>> index 535cb6a2543f..30366536f580 100644
>> --- a/arch/arm/boot/dts/qcom/pm8921.dtsi
>> +++ b/arch/arm/boot/dts/qcom/pm8921.dtsi
>> @@ -121,6 +121,13 @@ ref_muxoff: adc-channel@f {
>> reg = <0x00 0x0f>;
>> };
>> };
>> +
>> + usb_id: usb-detect {
>
> You should not mix non-addressable children with addressable. If you
> really do not have address, but other children have, then probably this
> is part of the main device, so should be folded into the parent node.
>
> Best regards,
> Krzysztof
