> -----Original Message----- > From: Paul Menzel <[email protected]> > Dear Tim, > > Thank you for your patch. > > Am 04.06.26 um 19:06 schrieb Tim Bird: > > Many bluetooth source files are missing SPDX-License-Identifier > > lines. Add appropriate IDs to these files, and remove other > > license lines from the headers. > > > > Leave the warranty disclaimer in files where the license ID is > > GPL-2.0 but the wording of the disclaimer is slightly different > > from that of the GPL v2 disclaimer. > > > > It is not different enough to cause licensing conflicts, but is > > kept to honor the original contributors' legal intent. > > Could you please add a note, why you use /* */ in header files (suffix > `.h`) and // in files ending with `.c`?
This is documented in the kernel policies for applying SPDX license identifier lines. See Documentation/process/license-rules.rst, Section 2. The reason is that some old tools that parse .h files do not (or at least did not at one time) correctly handle the '//' style comments. Did you want me to repeat this policy in the commit message? I'm not familiar with any other places where the official coding style is explicitly mentioned in the commit message, when the style is used in a contribution. -- Tim > > Signed-off-by: Tim Bird <[email protected]> > > --- > > V2 -> V3: > > - move Signed-off-by above changlog > > V1 -> V2: > > - Leave different warranty disclaimers (which is most them) > > - Remove files recently removed from drivers/bluetooth from the patch > > --- > > drivers/bluetooth/btrsi.c | 12 +----------- > > include/net/bluetooth/bluetooth.h | 5 +---- > > include/net/bluetooth/hci.h | 5 +---- > > include/net/bluetooth/hci_core.h | 5 +---- > > include/net/bluetooth/hci_mon.h | 5 +---- > > include/net/bluetooth/hci_sock.h | 5 +---- > > include/net/bluetooth/l2cap.h | 5 +---- > > include/net/bluetooth/mgmt.h | 5 +---- > > include/net/bluetooth/rfcomm.h | 5 +---- > > include/net/bluetooth/sco.h | 5 +---- > > net/bluetooth/af_bluetooth.c | 5 +---- > > net/bluetooth/bnep/core.c | 5 +---- > > net/bluetooth/bnep/netdev.c | 5 +---- > > net/bluetooth/bnep/sock.c | 5 +---- > > net/bluetooth/ecdh_helper.c | 5 +---- > > net/bluetooth/ecdh_helper.h | 5 +---- > > net/bluetooth/hci_conn.c | 5 +---- > > net/bluetooth/hci_core.c | 5 +---- > > net/bluetooth/hci_debugfs.c | 5 +---- > > net/bluetooth/hci_debugfs.h | 5 +---- > > net/bluetooth/hci_event.c | 5 +---- > > net/bluetooth/hci_sock.c | 5 +---- > > net/bluetooth/hidp/core.c | 5 +---- > > net/bluetooth/hidp/hidp.h | 5 +---- > > net/bluetooth/hidp/sock.c | 5 +---- > > net/bluetooth/l2cap_core.c | 5 +---- > > net/bluetooth/l2cap_sock.c | 5 +---- > > net/bluetooth/lib.c | 5 +---- > > net/bluetooth/mgmt.c | 5 +---- > > net/bluetooth/mgmt_util.c | 5 +---- > > net/bluetooth/mgmt_util.h | 5 +---- > > net/bluetooth/rfcomm/core.c | 5 +---- > > net/bluetooth/rfcomm/sock.c | 5 +---- > > net/bluetooth/rfcomm/tty.c | 5 +---- > > net/bluetooth/sco.c | 5 +---- > > net/bluetooth/selftest.c | 5 +---- > > net/bluetooth/selftest.h | 5 +---- > > net/bluetooth/smp.c | 5 +---- > > net/bluetooth/smp.h | 5 +---- > > 39 files changed, 39 insertions(+), 163 deletions(-) > > […] > > > Kind regards, > > Paul
