Hi Divya, kernel test robot noticed the following build warnings:
[auto build test WARNING on mst-vhost/linux-next] [also build test WARNING on linus/master v6.16-rc1 next-20260605] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Divya-Mankani/vsock-virtio-fix-memory-leak-in-virtio_transport_recv_listen/20260606-032557 base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next patch link: https://lore.kernel.org/r/20260605191922.12720-1-divyakm%40unc.edu patch subject: [PATCH] vsock/virtio: fix memory leak in virtio_transport_recv_listen config: s390-allnoconfig-bpf (https://download.01.org/0day-ci/archive/20260606/[email protected]/config) compiler: s390x-linux-gnu-gcc (Debian 14.2.0-19) 14.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260606/[email protected]/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <[email protected]> | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ All warnings (new ones prefixed by >>): net/vmw_vsock/virtio_transport_common.c: In function 'virtio_transport_recv_listen': >> net/vmw_vsock/virtio_transport_common.c:1538:13: warning: unused variable >> 'ret' [-Wunused-variable] 1538 | int ret; | ^~~ >> net/vmw_vsock/virtio_transport_common.c:1535:28: warning: unused variable >> 'vsk' [-Wunused-variable] 1535 | struct vsock_sock *vsk = vsock_sk(sk); | ^~~ vim +/ret +1538 net/vmw_vsock/virtio_transport_common.c c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1528 06a8fc78367d07 Asias He 2016-07-28 1529 /* Handle server socket */ 06a8fc78367d07 Asias He 2016-07-28 1530 static int 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1531 virtio_transport_recv_listen(struct sock *sk, struct sk_buff *skb, c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1532 struct virtio_transport *t) 06a8fc78367d07 Asias He 2016-07-28 1533 { 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1534 struct virtio_vsock_hdr *hdr = virtio_vsock_hdr(skb); 06a8fc78367d07 Asias He 2016-07-28 @1535 struct vsock_sock *vsk = vsock_sk(sk); 06a8fc78367d07 Asias He 2016-07-28 1536 struct vsock_sock *vchild; 06a8fc78367d07 Asias He 2016-07-28 1537 struct sock *child; c0cfa2d8a788fc Stefano Garzarella 2019-11-14 @1538 int ret; 06a8fc78367d07 Asias He 2016-07-28 1539 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1540 if (le16_to_cpu(hdr->op) != VIRTIO_VSOCK_OP_REQUEST) { a69686327e4291 Bobby Eshleman 2026-01-21 1541 virtio_transport_reset_no_sock(t, skb, sock_net(sk)); 06a8fc78367d07 Asias He 2016-07-28 1542 return -EINVAL; 06a8fc78367d07 Asias He 2016-07-28 1543 } 06a8fc78367d07 Asias He 2016-07-28 1544 06a8fc78367d07 Asias He 2016-07-28 1545 if (sk_acceptq_is_full(sk)) { a69686327e4291 Bobby Eshleman 2026-01-21 1546 virtio_transport_reset_no_sock(t, skb, sock_net(sk)); 06a8fc78367d07 Asias He 2016-07-28 1547 return -ENOMEM; 06a8fc78367d07 Asias He 2016-07-28 1548 } 06a8fc78367d07 Asias He 2016-07-28 1549 d7b0ff5a866724 Michal Luczaj 2024-11-07 1550 /* __vsock_release() might have already flushed accept_queue. d7b0ff5a866724 Michal Luczaj 2024-11-07 1551 * Subsequent enqueues would lead to a memory leak. d7b0ff5a866724 Michal Luczaj 2024-11-07 1552 */ d7b0ff5a866724 Michal Luczaj 2024-11-07 1553 if (sk->sk_shutdown == SHUTDOWN_MASK) { a69686327e4291 Bobby Eshleman 2026-01-21 1554 virtio_transport_reset_no_sock(t, skb, sock_net(sk)); d7b0ff5a866724 Michal Luczaj 2024-11-07 1555 return -ESHUTDOWN; d7b0ff5a866724 Michal Luczaj 2024-11-07 1556 } d7b0ff5a866724 Michal Luczaj 2024-11-07 1557 b9ca2f5ff7784d Stefano Garzarella 2019-11-14 1558 child = vsock_create_connected(sk); 06a8fc78367d07 Asias He 2016-07-28 1559 if (!child) { a69686327e4291 Bobby Eshleman 2026-01-21 1560 virtio_transport_reset_no_sock(t, skb, sock_net(sk)); 06a8fc78367d07 Asias He 2016-07-28 1561 return -ENOMEM; 06a8fc78367d07 Asias He 2016-07-28 1562 } 06a8fc78367d07 Asias He 2016-07-28 1563 06a8fc78367d07 Asias He 2016-07-28 1564 lock_sock_nested(child, SINGLE_DEPTH_NESTING); 06a8fc78367d07 Asias He 2016-07-28 1565 3b4477d2dcf270 Stefan Hajnoczi 2017-10-05 1566 child->sk_state = TCP_ESTABLISHED; 06a8fc78367d07 Asias He 2016-07-28 1567 06a8fc78367d07 Asias He 2016-07-28 1568 vchild = vsock_sk(child); 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1569 vsock_addr_init(&vchild->local_addr, le64_to_cpu(hdr->dst_cid), 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1570 le32_to_cpu(hdr->dst_port)); 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1571 vsock_addr_init(&vchild->remote_addr, le64_to_cpu(hdr->src_cid), 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1572 le32_to_cpu(hdr->src_port)); 06a8fc78367d07 Asias He 2016-07-28 1573 b09fac3ae8b655 Divya Mankani 2026-06-06 1574 /* Lock the parent listener socket to synchronize with a potential b09fac3ae8b655 Divya Mankani 2026-06-06 1575 * simultaneous shutdown thread running __vsock_release(). c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1576 */ b09fac3ae8b655 Divya Mankani 2026-06-06 1577 lock_sock(sk); b09fac3ae8b655 Divya Mankani 2026-06-06 1578 b09fac3ae8b655 Divya Mankani 2026-06-06 1579 /* Check if the listener socket was shut down while we were b09fac3ae8b655 Divya Mankani 2026-06-06 1580 * creating and configuring the child socket. b09fac3ae8b655 Divya Mankani 2026-06-06 1581 */ b09fac3ae8b655 Divya Mankani 2026-06-06 1582 if (sk->sk_shutdown == SHUTDOWN_MASK) { b09fac3ae8b655 Divya Mankani 2026-06-06 1583 release_sock(sk); c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1584 release_sock(child); a69686327e4291 Bobby Eshleman 2026-01-21 1585 virtio_transport_reset_no_sock(t, skb, sock_net(sk)); c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1586 sock_put(child); b09fac3ae8b655 Divya Mankani 2026-06-06 1587 return -ESHUTDOWN; c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1588 } c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1589 52bcb57a4e8a08 Dudu Lu 2026-04-13 1590 sk_acceptq_added(sk); 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1591 if (virtio_transport_space_update(child, skb)) c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1592 child->sk_write_space(child); c0cfa2d8a788fc Stefano Garzarella 2019-11-14 1593 06a8fc78367d07 Asias He 2016-07-28 1594 vsock_insert_connected(vchild); 06a8fc78367d07 Asias He 2016-07-28 1595 vsock_enqueue_accept(sk, child); 71dc9ec9ac7d3e Bobby Eshleman 2023-01-13 1596 virtio_transport_send_response(vchild, skb); 06a8fc78367d07 Asias He 2016-07-28 1597 b09fac3ae8b655 Divya Mankani 2026-06-06 1598 /* Safely release both locked objects */ b09fac3ae8b655 Divya Mankani 2026-06-06 1599 release_sock(sk); 06a8fc78367d07 Asias He 2016-07-28 1600 release_sock(child); 06a8fc78367d07 Asias He 2016-07-28 1601 06a8fc78367d07 Asias He 2016-07-28 1602 sk->sk_data_ready(sk); 06a8fc78367d07 Asias He 2016-07-28 1603 return 0; 06a8fc78367d07 Asias He 2016-07-28 1604 } 06a8fc78367d07 Asias He 2016-07-28 1605 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
