Re: [PATCH v13 16/22] KVM: selftests: Load per-vCPU guest stack in TDX boot parameters

[Binbin Wu]

On 5/22/2026 7:16 AM, Lisa Wang wrote:
> From: Sagi Shahar <sa...@google.com>
> 
> Allocate a guest stack for each vCPU and record the GVA in the TDX boot
> parameters region to allow proper vCPU initialization.
> 
> Co-developed-by: Ackerley Tng <ackerley...@google.com>
> Signed-off-by: Ackerley Tng <ackerley...@google.com>
> Signed-off-by: Sagi Shahar <sa...@google.com>
> Signed-off-by: Lisa Wang <wyi...@google.com>

Reviewed-by: Binbin Wu <binbin...@linux.intel.com>

One nit below.

[...]>  
> +void tdx_vcpu_load_boot_parameters(struct kvm_vm *vm, struct kvm_vcpu *vcpu)
> +{
> +     struct td_boot_parameters *params =
> +             addr_gpa2hva(vm, TD_BOOT_PARAMETERS_GPA);
> +     struct td_per_vcpu_parameters *vcpu_params =
> +             &params->per_vcpu[vcpu->id];
> +
> +     vcpu_params->esp_gva = kvm_allocate_vcpu_stack(vm);
> +}
> +
> +

An extra empty line.

>  static struct kvm_tdx_capabilities *tdx_read_capabilities(struct kvm_vm *vm)
>  {
>       struct kvm_tdx_capabilities *tdx_cap = NULL;
>